I wonder if it makes sense to add this option to open/test/jtreg-ext/requires/VMProps.java and have it automatically enable this option based on an environment variable so we don’t have to remember the cryptic command line sequence.
It’s too bad we can’t automatically detect that we are running in a container. Bob. > On Oct 23, 2020, at 2:50 PM, Harold Seigel <hsei...@openjdk.java.net> wrote: > > Please review this change to add an @requires mechanism called > "jdk.containerized" to help mark tests that are incompatible with containers. > Users would add "@requires jdk.containerized != true" to the incompatible > tests and then use "make test ... OPTIONS=-Djdk.containerized=true" or "bash > jib.sh mach5 -- remote-build-and-test ... --test-make-args > JTREG=OPTIONS=-Djdk.containerized=true" to exclude those tests when testing > with containers. > > ------------- > > Commit messages: > - 8238263: Create at-requires mechanism for containers > > Changes: https://git.openjdk.java.net/jdk/pull/844/files > Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=844&range=00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8238263 > Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/jdk/pull/844.diff > Fetch: git fetch https://git.openjdk.java.net/jdk pull/844/head:pull/844 > > PR: https://git.openjdk.java.net/jdk/pull/844
