On Fri, 23 Oct 2020 18:44:54 GMT, Harold Seigel <hsei...@openjdk.org> wrote:

> Please review this change to add an @requires mechanism called 
> "jdk.containerized" to help mark tests that are incompatible with containers. 
>  Users would add "@requires jdk.containerized != true" to the incompatible 
> tests and then use "make test ... OPTIONS=-Djdk.containerized=true" or "bash 
> jib.sh mach5 -- remote-build-and-test ... --test-make-args 
> JTREG=OPTIONS=-Djdk.containerized=true" to exclude those tests when testing 
> with containers.

Hi Harold,

I actually still think that having a separate ProblemList (as we do for graal, 
zgc, Xcomp, aot) is a better solution. why did you choose `@requires` over it?

-- Igor

-------------

PR: https://git.openjdk.java.net/jdk/pull/844

Reply via email to