On Thu, 19 Nov 2020 19:52:05 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once >> and, if not enough bytes have been skipped, then `read()` is invoked for >> each of the remaining bytes to be skipped. The proposed implementation >> instead repeatedly invokes `skip(long)` until the requested number of bytes >> has been skipped, or an error condition is encountered. For cases where >> `skip(long)` skips fewer bytes than the number requested, the new version >> was measured to be up to more than one thousand times faster than the old >> version. When `skip(long)` actually skips the requested number of bytes, the >> performance difference is insignificant. > > src/java.base/share/classes/java/io/InputStream.java line 596: > >> 594: * @see java.io.InputStream#skip(long) >> 595: */ >> 596: public void skipNBytes(long n) throws IOException { > > Not related to this change, but looks like `@since` is missing. https://bugs.openjdk.java.net/browse/JDK-8256183 ------------- PR: https://git.openjdk.java.net/jdk/pull/1329