> On Nov 19, 2020, at 12:04 PM, Brian Burkhalter <b...@openjdk.java.net> wrote:
> 
> On Thu, 19 Nov 2020 19:58:16 GMT, Naoto Sato <na...@openjdk.org 
> <mailto:na...@openjdk.org>> wrote:
> 
>> The code looks good. Should we also change the @implSpec, as it specifically 
>> describes how it works, i.e., calling no-arg read(), but the new impl calls 
>> read() with buffer.
> 
> Good catch. Yes, the `@implSpec` should be updated. I was too focused on the 
> code and performance test and missed that. I'll update that and file a CSR. 
> Thanks.

CSR filed [1]

Thanks,

Brian

[1] https://bugs.openjdk.java.net/browse/JDK-8256698

Reply via email to