On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski <[email protected]> wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>> + minor change of placements
>> - Use macro conditionals instead of empty functions
>> - Add W^X to tests
>> - Do not require known W^X state
>> - Revert w^x in gtests
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 297:
>
>> 295: stub = SharedRuntime::handle_unsafe_access(thread, next_pc);
>> 296: }
>> 297: } else if (sig == SIGILL && nativeInstruction_at(pc)->is_stop()) {
>
> Can we add a comment here describing what this case means?
this arm64 specific part came as is from linux_aarch64 and I can't add any
meaning comments here.
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 302:
>
>> 300: const uint64_t *detail_msg_ptr
>> 301: = (uint64_t*)(pc + NativeInstruction::instruction_size);
>> 302: const char *detail_msg = (const char *)*detail_msg_ptr;
>
> Where is `detail_msg` used?
Came from linux_arm64. was used in os_linux_aarch64.cpp on line 246 in
report_and_die
But became unused on bsd_arm64. I agree this needs to be removed
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 403:
>
>> 401: }
>> 402:
>> 403: return false; // Mute compiler
>
> Is this comment needed?
this part came as is from linux_aarch64 as well and was supposed to mean
something there.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2200
