On Thu, 4 Feb 2021 21:59:02 GMT, Gerard Ziemski <[email protected]> wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>> + minor change of placements
>> - Use macro conditionals instead of empty functions
>> - Add W^X to tests
>> - Do not require known W^X state
>> - Revert w^x in gtests
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 194:
>
>> 192: // may get turned off by -fomit-frame-pointer.
>> 193: frame os::get_sender_for_C_frame(frame* fr) {
>> 194: return frame(fr->link(), fr->link(), fr->sender_pc());
>
> Why is it
>
> return frame(fr->link(), fr->link(), fr->sender_pc());
>
> and not
>
> return frame(fr->sender_sp(), fr->link(), fr->sender_pc());
>
> like in the bsd-x86 counter part?
bsd_aarcb64 was based on linux_aarch64, with addition of bsd-specific things
from bsd_x86
You think the bsd-x86 is better here ?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2200
