On Thu, 4 Feb 2021 22:15:47 GMT, Gerard Ziemski <[email protected]> wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>> + minor change of placements
>> - Use macro conditionals instead of empty functions
>> - Add W^X to tests
>> - Do not require known W^X state
>> - Revert w^x in gtests
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 322:
>
>> 320: #ifdef __APPLE__
>> 321: } else if (sig == SIGFPE && info->si_code == FPE_NOOP) {
>> 322: Unimplemented();
>
> Is there a follow up issue for this?
Thanks, this is a leftover from the development phase, it will be removed. In
macos/x86, this looks like a workaround. We've never met with this condition
and it looks recent darwin kernel should correctly report the cause in si_code:
https://github.com/apple/darwin-xnu/blob/33eb9835cd948dbbcdd8741aa52457cbe507c765/bsd/dev/arm/unix_signal.c#L436.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2200
