On Fri, 19 Nov 2021 17:24:15 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276764: Enable deterministic file content ordering for Jar and Jmod
>>
>> Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>
> test/jdk/tools/jar/CreateJarBenchmark.java line 56:
>
>> 54: import jdk.test.lib.util.FileUtils;
>> 55:
>> 56: public class CreateJarBenchmark {
>
> This is a benchmark which should not be run as regression testing. I wonder
> if we need this benchmark for future use. If so I would suggest to convert
> it to JMH and place it under `test/micro/org/openjdk/bench/tools/jar`
> directory. I'm okay with or without it in this patch.
@LanceAndersen what's your opinion? I'm not totally sure of it's usefulness?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6395
