On Fri, 19 Nov 2021 18:13:47 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> test/jdk/tools/jar/CreateJarBenchmark.java line 56:
>>
>>> 54: import jdk.test.lib.util.FileUtils;
>>> 55:
>>> 56: public class CreateJarBenchmark {
>>
>> This is a benchmark which should not be run as regression testing. I
>> wonder if we need this benchmark for future use. If so I would suggest to
>> convert it to JMH and place it under
>> `test/micro/org/openjdk/bench/tools/jar` directory. I'm okay with or
>> without it in this patch.
>
> @LanceAndersen what's your opinion? I'm not totally sure of it's usefulness?
My thought is to remove it from this PR, since we've already determined the
change has little impact.
We can raise a new issue if we feel it's needed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6395
