On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no >> ordering of the return file lists, and in fact rely on OS query file >> ordering, which can differ by underlying OS architecture. >> This PR adds sort processing to the creation of such jar's and jmod's to >> enable a deterministic content ordering. >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> > > Andrew Leonard has updated the pull request incrementally with one additional > commit since the last revision: > > 8276764: Enable deterministic file content ordering for Jar and Jmod > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> The changes look OK. Have you run the JCK tests in addition to the Mach5 tests for the areas being changed to make sure we did not trip over a conformance test? ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6395
