On Mon, 29 Nov 2021 18:32:30 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Following integration of the second incubator of the foreign function and >> memory API [1], we detected few divergences between the contents of the jdk >> repo and the panama repo: >> >> * the name of some of the `FunctionDescriptor` wither methods is different >> (e.g. `withAppendedLayoutArguments` vs. `appendLayoutArguments`), as it has >> been simplified and improved following a change that was not incorporated in >> [1]. >> >> * TestUpcall does not execute all the test combinations, because of an issue >> in the jtreg header (also fixed in the panama repo) >> >> * Addressing some feedback, we would like to bring back alignment to >> JAVA_INT layout constants (and related constants). >> >> Javadoc: >> http://cr.openjdk.java.net/~mcimadamore/8277924/v1/javadoc/jdk/incubator/foreign/package-summary.html >> Specdiff: >> http://cr.openjdk.java.net/~mcimadamore/8277924/v1/spec_diff/overview-summary.html >> >> [1] - #5907 > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the last revision: > > Update > src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ValueLayout.java > > Co-authored-by: Jorn Vernee <jornver...@users.noreply.github.com> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ValueLayout.java line 619: > 617: */ > 618: public static final OfDouble JAVA_DOUBLE = new > OfDouble(ByteOrder.nativeOrder()) > 619: .withBitAlignment(ADDRESS_SIZE_BITS); The code here is still using `ADDRESS_SIZE_BITS` (same for JAVA_LONG), instead of `64` as the javadoc says. Not sure that is intended? ------------- PR: https://git.openjdk.java.net/jdk/pull/6589
