On Fri, 25 Mar 2022 12:33:21 GMT, Richard Startin <d...@openjdk.java.net> wrote:

>> Claes Redestad has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add nanoOfSecond parameter, make micro less reliant on constants
>
> test/micro/org/openjdk/bench/java/time/GetYearBench.java line 70:
> 
>> 68:     private static final long[] INSTANT_MILLIS = createInstants();
>> 69: 
>> 70:     private static final int[] YEARS = new int[INSTANT_MILLIS.length];
> 
> Does it make any difference if these aren't constant?

Interestingly a slight increase in the measured gain (14% -> 25%). I think we 
should favor non-constant data to subdue irrelevant JIT shenanigans so I pushed 
the changes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7957

Reply via email to