On Tue, 26 Jul 2022 02:15:55 GMT, Bill Huang <d...@openjdk.org> wrote:

>> Provided coverage for XPath node set functions. Functions include:
>> - id()
>> - last()
>> - position()
>> - count()
>> - local-name()
>> - namespace-uri()
>> - name()
>
> Bill Huang has refreshed the contents of this pull request, and previous 
> commits have been removed. The incremental views will show differences 
> compared to the previous content of the PR. The pull request contains one new 
> commit since the last revision:
> 
>   Fixed validation error by renaming attributes to be starting with non-digit 
> charaters.

Nice tests overall. Some documentation would be good, that is, 
javadocs/comments/notes to fields, DataProviders and test methods. 

For name, namespace functions, it would be good to test them against XMLs with 
namespaces so that the results may contain elements/attributes that are 
relevant to the namespace.

-------------

PR: https://git.openjdk.org/jdk/pull/9633

Reply via email to