On Tue, 26 Jul 2022 19:44:51 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> Bill Huang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> Fixed validation error by renaming attributes to be starting with >> non-digit charaters. > > Nice tests overall. Some documentation would be good, that is, > javadocs/comments/notes to fields, DataProviders and test methods. > > For name, namespace functions, it would be good to test them against XMLs > with namespaces so that the results may contain elements/attributes that are > relevant to the namespace. @JoeWang-Java Thank you for the advice. I added a foo namespace for the name and namespace functions. More comprehensive test coverage for namespaces will be covered by [JDK-8289510](https://bugs.openjdk.org/browse/JDK-8289510). ------------- PR: https://git.openjdk.org/jdk/pull/9633
