On Wed, 24 Aug 2022 16:02:25 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Add support for named groups to java.util.regex.MatchResult
>
> src/java.base/share/classes/java/util/regex/MatchResult.java line 274:
> 
>> 272:      *          might be preferable for other reasons.
>> 273:      *
>> 274:      * @since 20
> 
> Should the method declare that it throws `UnsupportedOperationsExceptions`?
> Because that is what will happen if `namedGroups` is not 
> overridden/implemented.
> 
> Same comment for the other new methods.

Not sure.
If the convention is to document every single `RuntimeException` that methods 
invoked by this one could throw, then yes.
In other words, should `RuntimeExcpetion`s thrown deep in an invocation stack 
be documented in every caller method?

-------------

PR: https://git.openjdk.org/jdk/pull/10000

Reply via email to