On Wed, 24 Aug 2022 17:34:17 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Not sure.
>> If the convention is to document every single `RuntimeException` that 
>> methods invoked by this one could throw, then yes.
>> In other words, should `RuntimeExcpetion`s thrown deep in an invocation 
>> stack be documented in every caller method?
>
> In principle, yes. In practice, I see that `namedGroups` doesn't have an 
> `@throws UnsupportedOperationException` but has an `@implSpec` that says that 
> the default implementation throws `UnsupportedOperationException`. This seems 
> strange to me - maybe @stuart-marks or @jddarcy can comment.
> 
> What I was hinting at here however is that we might want to extend the 
> `@implSpec` of the new methods to note that these method will throw 
> `UnsuportedOperationException` if `namedGroups` is not implemented (like the 
> `@implSpec` of `namedGroups` does).

Ah, I see.
So what you mean is not adding another @throws clause but to either improve 
@implNote or, better, to add @implSpec.

-------------

PR: https://git.openjdk.org/jdk/pull/10000

Reply via email to