On Fri, 26 Aug 2022 10:36:41 GMT, Raffaello Giulietti <d...@openjdk.org> wrote:

>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8065554: MatchResult should provide values of named-capturing groups

Good updates to the test, the `@throws` clauses, and the `@implNote` in the 
class specification. I don't know if I was clear before, but all the new 
default methods require `@implSpec` clauses that explain in some detail what 
they do, in particular self-use -- see my [previous 
comment](https://github.com/openjdk/jdk/pull/10000#discussion_r955530412). (Or 
maybe you're still working on this.)

-------------

PR: https://git.openjdk.org/jdk/pull/10000

Reply via email to