On Tue, 20 Sep 2022 18:08:21 GMT, Lance Andersen <lan...@openjdk.org> wrote:
> Assuming we are set with the other changes, did you want to add the following > paragraph (or similar) at line 58 to make it clear that if the Manifest is > not found, then the JarEntry attributes will not be available: This is something the reader can read about in the Signed JAR section of the JAR file spec and I think it's too much to try to include in this section of JarInputStream. If there is a place for this in JarInputStream then it's probably in the method description of getNextJarEntry as that can talk about the properties of the JarEntry that it returns. You could separate that out to a separate issue if you want. ------------- PR: https://git.openjdk.org/jdk/pull/10045
