On Tue, 20 Sep 2022 18:08:23 GMT, Lance Andersen <[email protected]> wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this update, we are finally documenting
>> behavior that dates back to when this class was added to JDK 1.2
>>
>>
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added the verification note from JarFile
As a side comment, I notice that `JarInputStream` capitalizes "JAR", whereas
`JarFile` does not ("jar"). We should really be consistent in our javadocs. I
think "JAR" is more correct, mainly because that is what the Jar File
specification uses.
I am not suggesting you need to change `JarFile` though this as part of this
PR. Mostly noting it for future reference.
-------------
PR: https://git.openjdk.org/jdk/pull/10045
