On Fri, 28 Oct 2022 22:43:34 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove old ids hack, has no usage > > test/jdk/java/util/Formatter/Basic-X.java.template line 1612: > >> 1610: list.remove("America/WhiteHorse"); >> 1611: list.remove("Canada/Yukon"); >> 1612: ids = list.toArray(new String[list.size()]); > > It's not your change but I just noticed this. Since we specifically test only > for `CLDR` provider (as in `BasicTestLauncher`), I wonder we could remove > this portion. Even if we do need this piece, it could be simplified as: > > ids = Arrays.stream(ids).filter(tz -> !tz.equals(...)).toArray(String[]::new) Removing portion since it is no longer used/needed. Tests passing without. ------------- PR: https://git.openjdk.org/jdk/pull/10910