On Mon, 31 Oct 2022 17:50:47 GMT, Justin Lu <d...@openjdk.org> wrote:
>> Issue: Duplication of methods between Basic*.java test classes, due to auto >> generation by genBasic.sh >> >> Fix: Reorganize parts of Basic-X.java.template into base class in >> Basic.java. Toggled -nel flag for generation script (genBasic.sh) to remove >> excessive white space. Moved a previous direct change to BasicDateTime.java >> into the template. >> >> Note: Main files to look at are Basic.java and Basic-X.java.template, as the >> rest are a reflection of the auto generation > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Remove old ids hack, has no usage thank you for the clean up Justin. I think this looks much better and more maintainable ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.org/jdk/pull/10910
