On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> Option --disable-@files is not recognised as valid JVM option, however it is > already implemented in the launcher. > Proposed patch skips --disable-@files option in > src/hotspot/share/runtime/arguments.cpp processing, so it does not fall into > the category of unknown options. > The patch also corrects typo in the launcher.properties and adds simple > DisableFilesOptionTest. > > Please review. > > Thank you, > Adam As far as I can see @-file processing is a launcher feature, including the expansion of JDK_JAVA_OPTIONS, so it should never be getting passed through to the VM in the first place. What I can't figure out is how the test tools/launcher/ArgsFileTest.java is working when the JVM won't start with that flag on the command-line ?? BTW for future reference for the test case we are no longer creating tests using the bug id as a directory, instead tests should be grouped into functional areas. Thanks. I was also surprised to see the i8N changes here as I thought that was normally handled seperately. ------------- Changes requested by dholmes (Reviewer). PR: https://git.openjdk.org/jdk/pull/11183
