On Thu, 17 Nov 2022 01:26:51 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Option --disable-@files is not recognised as valid JVM option, however it is >> already implemented in the launcher. >> Proposed patch skips --disable-@files option in >> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall into >> the category of unknown options. >> The patch also corrects typo in the launcher.properties and adds simple >> DisableFilesOptionTest. >> >> Please review. >> >> Thank you, >> Adam > > BTW for future reference for the test case we are no longer creating tests > using the bug id as a directory, instead tests should be grouped into > functional areas. Thanks. > > I was also surprised to see the i8N changes here as I thought that was > normally handled seperately. @dholmes-ora and @AlanBateman thanks for pointing me to the right place for the fix. tools/launcher/ArgsFileTest.java was working because it didn't contain any test with --disable-@files option verifying VM really starts ------------- PR: https://git.openjdk.org/jdk/pull/11183
