On Fri, 18 Nov 2022 18:38:46 GMT, Joe Darcy <[email protected]> wrote:
>> test/jdk/java/lang/Thread/BuilderTest.java line 29:
>>
>>> 27: * @enablePreview
>>> 28: * @compile BuilderTest.java
>>> 29: * @run testng/othervm BuilderTest
>>
>> I assume `@compile` can be dropped from most of these tests now. Also I
>> think /othervm can be dropped too because jtreg will always use othervm for
>> tests that require --enable-preview. When the feature becomes permanent then
>> it would mean dropping the `@enablePreview` tag, no other changes.
>
> Right; ideally when the feature becomes non-preview the test update would
> just be removing the "@enablePreview" line. I didn't author these tests so I
> initially left any "othervm" directives in place since they aren't incorrect,
> just at worst a bit inefficient.
`@enablePreview` wasn't available when most of these tests were initially
created. I changed some of to use this tag as part of other changes but didn't
cover over the remaining tests that still use `@compile --enable-preview
-source ${jdk.version} ...` and `@run main/othervm --enable-preview ...`. I
just scanned the tests in test/jdk/java/lang/Thread/virtual and they can all be
changed the same way, if you want. If you leave it then we'll just change them
at the next edit in this area.
-------------
PR: https://git.openjdk.org/jdk/pull/11222
