On Fri, 18 Nov 2022 19:06:02 GMT, Alan Bateman <[email protected]> wrote:
>> Right; ideally when the feature becomes non-preview the test update would
>> just be removing the "@enablePreview" line. I didn't author these tests so I
>> initially left any "othervm" directives in place since they aren't
>> incorrect, just at worst a bit inefficient.
>
> `@enablePreview` wasn't available when most of these tests were initially
> created. I changed some of to use this tag as part of other changes but
> didn't cover over the remaining tests that still use `@compile
> --enable-preview -source ${jdk.version} ...` and `@run main/othervm
> --enable-preview ...`. I just scanned the tests in
> test/jdk/java/lang/Thread/virtual and they can all be changed the same way,
> if you want. If you leave it then we'll just change them at the next edit in
> this area.
I think I got most of those in the PR. There was a file or two I didn't update
because not all the @compile/@run directives in the file used --enablePreview
and the @enablePreview directive applies to all @compile and @run directives.
-------------
PR: https://git.openjdk.org/jdk/pull/11222
