On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato <[email protected]> wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.internal.le` terminal by default, or jshell implementation if
>> available. A corresponding CSR has been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed the copyright year
src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java
line 50:
> 48: * {@inheritDoc}
> 49: */
> 50: public JdkConsole console(boolean isTTY) {
Hello Naoto, this is missing a `@Override`.
src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java
line 58:
> 56: * public Console class.
> 57: */
> 58: public static class JdkConsoleImpl implements JdkConsole {
Can this be `private` class? Also, the methods in this class are missing the
`@Override`.
-------------
PR: https://git.openjdk.org/jdk/pull/11421
