On Thu, 15 Dec 2022 12:24:34 GMT, Alan Bateman <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved echo() to ConsoleImpl, clean-ups
>
> src/java.base/share/classes/java/io/Console.java line 111:
>
>> 109: public PrintWriter writer() {
>> 110: throw new UnsupportedOperationException(
>> 111: "Console class itself does not provide implementation");
>
> Minor comment is the same "throw new UOE(message)" is repeated in every
> method. You could add a static method to return it, then it would reduce to
> "throw newUnsupportedOperationException();".
>
> Also looks like the method descriptions on all these methods starts at
> position 3. Pre-dates your change but since every method is changed then
> maybe we should fix that too, up to you.
Thanks, Alan. Addressed both.
-------------
PR: https://git.openjdk.org/jdk/pull/11615
