On Tue, 17 Jan 2023 13:33:06 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Hi all, >> >> Please review the fix for the build failure with clang-15. >> >> 1. -Wbitwise-instead-of-logical >> >> 1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the >> warning >> 2) src/hotspot/share/runtime/notificationThread.cpp <--- keep the code >> and disable warnings >> 3) src/hotspot/share/runtime/serviceThread.cpp <--- keep the code >> and disable warnings >> >> >> 2. -Wdeprecated-non-prototype (all the warnings are disabled) >> >> 1) Mainly caused by files under `src/java.base/share/native/libzip/zlib/` >> <--- keep the code and disable warnings >> It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN. >> >> 2) While compiling >> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c <--- >> keep the code and disable warnings >> >> 3) Caused by >> src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m <--- fixed >> the warnings >> >> >> 3. -Wdeprecated-builtins >> >> Caused by files under src/java.desktop/share/native/libharfbuzz/ <--- >> fixed the warnings >> >> Ref: https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-meta.hh#L202 >> >> 4. -Wgnu-folding-constant >> >> Caused by >> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m <--- >> keep the code and disable warnings >> >> >> Thanks. >> Best regards, >> Jie > > Yes, but I would wait for @prrace to review the Harfbuzz change. > Hi @kevinrushforth and @AlanBateman , are you fine with this change? No objection from me but I agree with Kevin to wait to see what Phil says about Harfbuzz. ------------- PR: https://git.openjdk.org/jdk/pull/12005
