On Wed, 15 Mar 2023 16:42:53 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed SystemModulesPlugin
These convenient methods really simplify it and improve the readability.
This patch seems to fix `BasicTest.java` test failure I mentioned to you
offline. What was the issue with the previous revision?
$ JTwork/scratch/mysmallimage/bin/java -Xlog:init=debug -m test/jdk.test.Test
Error occurred during initialization of boot layer
java.lang.InternalError: java.lang.ClassNotFoundException:
jdk/internal/module/SystemModules$all
at
java.base/jdk.internal.module.SystemModuleFinders.systemModules(SystemModuleFinders.java:132)
at
java.base/jdk.internal.module.ModuleBootstrap.boot2(ModuleBootstrap.java:228)
at
java.base/jdk.internal.module.ModuleBootstrap.boot(ModuleBootstrap.java:174)
at java.base/java.lang.System.initPhase2(System.java:2222)
Caused by: java.lang.ClassNotFoundException:
jdk/internal/module/SystemModules$all
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:391)
at java.base/java.lang.Class.forName(Class.java:382)
at
java.base/jdk.internal.module.SystemModuleFinders.systemModules(SystemModuleFinders.java:129)
... 3 more
-------------
PR: https://git.openjdk.org/jdk/pull/12944
