On Thu, 16 Mar 2023 20:45:24 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> I further clarified with Naoto and I now understand the problem.    The 
>> plugin intends to transform `.class` that implements `LocaleDataMetaInfo` in 
>> `jdk.localedata` module.   It's a bug in the plugin `--include-locales=*` 
>> which will read all resources from `jdk.localedata` with ASM ClassReader and 
>> the plugin just happens to work.  The plugin should only read `.class` 
>> entries or specific `LocaleDataMetaInfo` implementation classes.    I 
>> created https://bugs.openjdk.org/browse/JDK-8304367 that Naoto will help 
>> fixing. 
>> 
>> @asotona your previous version converting it to ClassFile API should work 
>> after JDK-8304367.
>
> Submitted: https://github.com/openjdk/jdk/pull/13067

I've reverted `IncludeLocalesPlugin` to previous version, plus minor fixes and 
together with #13067 the `IncludeLocalesPluginTest` is passing.
Thank you.

-------------

PR: https://git.openjdk.org/jdk/pull/12944

Reply via email to