On Tue, 24 Jan 2023 14:02:26 GMT, Per Minborg <[email protected]> wrote:
> This PR proposed to retire the class 'java.io.ExpiringCache'. The use of the
> class has been off by default since Java 16 but could be explicitly turned on
> by means of two System properties.
The removal looks okay okay. There is some noise in this patch with changes
that are nothing to do with the PR but I think are okay.
src/java.base/unix/classes/java/io/DefaultFileSystem.java line 34:
> 32: final class DefaultFileSystem {
> 33:
> 34: private DefaultFileSystem() {}
This seems to be another drive-up change, there is only one implementation to
making it final might be useful to people reading this code.
src/java.base/unix/classes/java/io/UnixFileSystem.java line 140:
> 138: @Override
> 139: public boolean isInvalid(File f) {
> 140: return f.getPath().indexOf('\u0000') >= 0;
This seems to be another drive-by change but looks okay.
src/java.base/unix/classes/java/io/UnixFileSystem.java line 358:
> 356: @Override
> 357: public int getNameMax(String path) {
> 358: return (int)Math.min(getNameMax0(path), Integer.MAX_VALUE);
This change is nothing to do with this issue. It's okay to refactor it as a
drive-by change but I think keep nameMax as that made it easier to debug.
src/java.base/windows/classes/java/io/WinNTFileSystem.java line 429:
> 427: if (s != null) return s;
> 428: s = getDriveDirectory(i + 1);
> 429: DRIVE_DIR_CACHE[i] = s;
This change is nothing to do with this PR but it looks okay.
-------------
PR Review: https://git.openjdk.org/jdk/pull/12167#pullrequestreview-1352635189
PR Review Comment: https://git.openjdk.org/jdk/pull/12167#discussion_r1144852146
PR Review Comment: https://git.openjdk.org/jdk/pull/12167#discussion_r1144867801
PR Review Comment: https://git.openjdk.org/jdk/pull/12167#discussion_r1144848624
PR Review Comment: https://git.openjdk.org/jdk/pull/12167#discussion_r1144855446
