On Tue, 28 Mar 2023 06:55:26 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> This PR proposed to retire the class 'java.io.ExpiringCache'. The use of the >> class has been off by default since Java 16 but could be explicitly turned >> on by means of two System properties. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revert change after comments src/java.base/windows/classes/java/io/WinNTFileSystem.java line 425: > 423: // Updates might not be visible to other threads so there > 424: // is no guarantee getDriveDirectory(i+1) is called just once > 425: // for any given value of i. I found this comment a bit odd in this PR, since this isn't related to any changes in this PR and this behaviour has been this way even in mainline. I'm guessing this has been added just as an informational comment for future maintainers of this code to be aware of this detail; and that's fine with me. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12167#discussion_r1150157968
