On Wed, 29 Mar 2023 19:06:20 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify handling of cached keySet, values, and entrySet views. > > src/java.base/share/classes/java/util/SequencedCollection.java line 107: > >> 105: */ >> 106: default void addFirst(E e) { >> 107: throw new UnsupportedOperationException(); > > Can this be defaulted to `this.reversed().addLast()` instead? If this throws > uoe, the reversed should throw uoe as well; and the new default can simplify > implementations by much as well. In the same spirit, `reversed()` should also have a default implementation equivalent to Collections.unmodifiableSequenceCollection(Arrays.asList(this.toArray())).reversed() ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1152384938