On Wed, 29 Mar 2023 04:21:10 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to >> write some more implementation-specific tests around decision points in the >> FDLIBM algorithm, but I wanted to get the bulk of the changes out for review >> first. >> >> Note that since IEEEremainder was the last native method in StrictMath.java, >> the StrictMath.c file needed to be deleted (or modified) since StrictMath.h >> was no longer generated as part of the build. (StrictMath.c was one of the >> file deleted as part of JDK-8302801). >> >> For testing, Mach 5 tier 1 through 3 were successful (other than an >> unrelated test failure that was problem listed) and the exhaustive test was >> locally run and passed with "16, 16" to increase the testing density. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Appease jcheck. LGTM2 ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13113#pullrequestreview-1367445754
