On Wed, 29 Mar 2023 01:47:35 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> test/jdk/tools/jlink/plugins/CDSPluginTest.java line 97: >> >>> 95: // separate --module-path will force the JLink task to read >>> the ModuleTarget from >>> 96: // the java.base module-info.class to identify the target >>> platform for the image >>> 97: // being generated. >> >> I'm a bit uncomfortable with change the test for the CDS plugin as part of >> this change but can live with it. > > Early on during this PR, we decided and implemented to read the > `ModuleTarget` only if the java.base module's file path doesn't match that of > the current platform's file path. If we remove that check and instead always > read the ModuleTarget of java.base, in the JLinkTask, we won't need any > changes to this test, since the JLinkTask will rightly find the correct > target platform from the module-info.class. Furthermore, rest of the cross > platform image generation would work fine too. > > Do you think we should remove that file path check? I am guessing the reason > why the file path checks were suggested was to reduce any chances of > regression with these current changes? My preference would be to drop this as it insane to run with -Dos.name=window set on Linux. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1157089625
