On Tue, 4 Apr 2023 11:09:24 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Early on during this PR, we decided and implemented to read the >> `ModuleTarget` only if the java.base module's file path doesn't match that >> of the current platform's file path. If we remove that check and instead >> always read the ModuleTarget of java.base, in the JLinkTask, we won't need >> any changes to this test, since the JLinkTask will rightly find the correct >> target platform from the module-info.class. Furthermore, rest of the cross >> platform image generation would work fine too. >> >> Do you think we should remove that file path check? I am guessing the reason >> why the file path checks were suggested was to reduce any chances of >> regression with these current changes? > > My preference would be to drop this as it insane to run with -Dos.name=window > set on Linux. I'm working on an update to jlink to use jdk.internal.misc.OperatingSystem instead of os.name (PR #12931), setting os.name on the command line will have no effect. (The test will be updated or removed). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1157265431
