On Thu, 13 Apr 2023 15:27:12 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 75 commits: >> >> - Merge branch 'master' into 8285932 >> - Change MAX_INDY_CONCAT_ARG_SLOTS to be updatable. >> - Clean up Error handling >> - Recommended changes >> - RuntimeException is the only exception type that can is deduced from a >> lambda. >> - Update combine example >> - Merge branch 'master' into 8285932 >> - Update StringTemplate.combine javadoc >> - Requested review changes. >> - Clean up list construction >> - ... and 65 more: https://git.openjdk.org/jdk/compare/bc151633...f1b187a1 > > src/java.base/share/classes/java/lang/runtime/Carriers.java line 554: > >> 552: >> 553: /** >> 554: * Class used to tally ahd track the number of ints, longs and >> objects. > > typo: ahd Will fix. > src/java.base/share/classes/jdk/internal/util/FormatConcatItem.java line 37: > >> 35: * @since 21 >> 36: */ >> 37: @PreviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES) > > Generally, The `PreviewFeature` annotation is not needed on internal APIs and > serves little purpose. PreviewFeature might be heavy handed. I can replace it with a warning to not depend on this file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165915844 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165915665