On Sat, 13 May 2023 14:11:11 GMT, Chen Liang <li...@openjdk.org> wrote:

>> The jdk.internal.classfile.components package's interfaces have 
>> implementations in their nested classes, which are implicitly public and 
>> exported with the package. They are now moved to the impl package to avoid 
>> unwanted exposures. Fixed a few minor javadoc issues in the interfaces as 
>> well.
>> 
>> In conflict with #13021; one needs updating if the other is merged.
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The pull request now contains three commits:
> 
>  - merge indy remap fix
>  - Merge branch 'master' into fix/hide-component-impl
>  - 8306457: Classfile API components implementations should not be exposed

I would prefer to keep formatting when moving large block of code from one 
source file to another. It is very hard to diff and requires deep review 
otherwise.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13541#pullrequestreview-1426101972

Reply via email to