On Tue, 16 May 2023 18:10:08 GMT, Chen Liang <li...@openjdk.org> wrote:
>> The jdk.internal.classfile.components package's interfaces have >> implementations in their nested classes, which are implicitly public and >> exported with the package. They are now moved to the impl package to avoid >> unwanted exposures. Fixed a few minor javadoc issues in the interfaces as >> well. >> >> In conflict with #13021; one needs updating if the other is merged. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains five commits: > > - Don't change formatting in the migration > > The changes are done by copying old implementation and removing one level > (4 spaces) of indent. > The constructors of CodeLocalsShifterImpl and CodeStackTrackerImpl are > promoted to public > - Merge branch 'master' into fix/hide-component-impl > - merge indy remap fix > - Merge branch 'master' into fix/hide-component-impl > - 8306457: Classfile API components implementations should not be exposed Looks good, thank you. ------------- Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13541#pullrequestreview-1430647466
