On Mon, 15 May 2023 06:45:45 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> test/jdk/tools/launcher/InstanceMainTest.java line 31:
>
>> 29: * @run main InstanceMainTest
>> 30: */
>> 31: public class InstanceMainTest extends TestHelper {
>
> Are you planning to add tests for the selection/precedence order?
>
> Also wondering if we need a test to check that there is a warning when the
> main method in found in the super class.
InstanceMainTest does check precedence. Are you expecting a test for all
combinations?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13689#discussion_r1194117636
