On Mon, 5 Jun 2023 16:30:16 GMT, Brian Goetz <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolBuilder.java
> line 82:
>
>> 80: static ConstantPoolBuilder of() {
>> 81: return new SplitConstantPool();
>> 82: }
>
> The old ctors here were (ClassModel) and (Options), where the ClassModel
> version had a trail of breadcrumbs back to options. The new ctors are
> (ClassModel) and no-args, which is a slight departure. What use did CPB make
> of options in the first place, if any?
CPB was only holder of options and others took the options from CPB.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14180#discussion_r1218391052
