On Mon, 5 Jun 2023 15:14:35 GMT, Brian Goetz <briango...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 50:
>
>> 48: /**
>> 49: * Main entry points for parsing, transforming, and generating
>> classfiles.
>> 50: */
>
> Now that this is not just a bag of static methods any more, we need to have
> some spec text about what a Classfile is. Something like:
>
> Represents a context for parsing, transforming, and generating classfiles. A
> `Classfile` has a set of options that condition how parsing and generation is
> done.
Fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 54:
>
>> 52: permits ClassfileImpl {
>> 53:
>> 54: static Classfile of() {
>
> Classfile::of needs specification
Fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 63:
>
>> 61:
>> 62: Classfile withOptions(Option... options);
>> 63:
>
> Classfile::withOptions needs specification
Fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 66:
>
>> 64: /**
>> 65: * An option that affects the writing of classfiles.
>> 66: */
>
> Options affect parsing as well as writing now
Fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14180#discussion_r1218431266
PR Review Comment: https://git.openjdk.org/jdk/pull/14180#discussion_r1218431345
PR Review Comment: https://git.openjdk.org/jdk/pull/14180#discussion_r1218431300
PR Review Comment: https://git.openjdk.org/jdk/pull/14180#discussion_r1218431386
