On Wed, 14 Jun 2023 06:03:48 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Convert the note in fromDescriptorString to apiNote
>
> src/java.base/share/classes/java/lang/Class.java line 928:
>
>> 926: * @apiNote
>> 927: * This is not a strict inverse of {@link #forName(String) forName}.
>> 928: * For normal classes, distinct classes which share a common name
>> but
>
> Readers may wonder what "normal classes" means here, it might be simpler to
> just drop introducing that term and just use the structure from the note
> removed from descriptorString.
This might wish to refer to "classes that can be described nominally", but same
might be said for hidden classes as well. So your suggestion is better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14411#discussion_r1229124490
