On Thu, 15 Jun 2023 10:01:31 GMT, Alan Bateman <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the note for getName
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java line 1233:
>
>> 1231: * (JVMS {@jvms 4.3.3}) and a suitable class loader argument. Two
>> distinct
>> 1232: * classes which share a common name but have different class
>> loaders will
>> 1233: * appear identical when viewed within descriptor strings.
>
> "will appear identical when viewed within descriptor strings". Would it be
> clearer to say that have equal descriptor strings?
How about this:
"A method type produced by changing a component type to a distinct class with
the same name but a different class loader will have the same descriptor string"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14411#discussion_r1237878347