On Thu, 22 Jun 2023 09:13:21 GMT, Artem Semenov <aseme...@openjdk.org> wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update
make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241:
> 239: DISABLED_WARNINGS_gcc_OGLPaints.c := format-nonliteral, \
> 240: DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c :=
> parentheses, \
> 241: DISABLED_WARNINGS_gcc_X11SurfaceData.c :=
> implicit-fallthrough pointer-to-int-cast, \
Suggestion:
DISABLED_WARNINGS_gcc_GLXSurfaceData.c := unused-function, \
DISABLED_WARNINGS_gcc_gtk2_interface.c := parentheses type-limits, \
DISABLED_WARNINGS_gcc_gtk3_interface.c := parentheses type-limits
unused-function, \
DISABLED_WARNINGS_gcc_OGLBufImgOps.c := format-nonliteral, \
DISABLED_WARNINGS_gcc_OGLPaints.c := format-nonliteral, \
DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c := parentheses, \
DISABLED_WARNINGS_gcc_X11SurfaceData.c := implicit-fallthrough
pointer-to-int-cast, \
make/modules/java.desktop/lib/Awt2dLibraries.gmk line 260:
> 258: DISABLED_WARNINGS_clang_aix_sun_awt_X11_GtkFileDialogPeer.c :=
> parentheses, \
> 259: DISABLED_WARNINGS_clang_aix_awt_InputMethod.c := sign-compare, \
> 260: DISABLED_WARNINGS_clang_screencast_pipewire.c :=
> format-nonliteral, \
move this one closer to the other clang (non-aix) suppressions
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1238296391
PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1238297332
