On Fri, 23 Jun 2023 06:10:05 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Revert wrong Copyright >> - Copyright > > src/java.desktop/windows/native/libawt/windows/awt_Menu.h line 76: > >> 74: /*for multifont menu */ >> 75: BOOL IsTopMenu(); >> 76: virtual AwtMenuItem* GetItem(jobject target, int index); > > Hi @aivanov-jdk are you OK leaving this inconsistent with the definition? > https://github.com/openjdk/jdk/blob/16b5a91461db1765e2e7596ebaaf1299cec9b0c8/src/java.desktop/windows/native/libawt/windows/awt_Menu.cpp#L261 The declaration and implementation have to match. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1239886709
