On Tue, 1 Aug 2023 06:29:28 GMT, sid8606 <d...@openjdk.org> wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Fix typo > > Signed-off-by: Sidraya <sidraya.jayag...@ibm.com>
src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 154: > 152: } else { > 153: assert(to_reg.stack_size() == 4, "size should match"); > 154: // s390 needs 4 Byte offset Seems like this comment should get removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1285880721