On Fri, 14 Jul 2023 16:08:12 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>>> It's looking pretty good.
>> 
>> Thank you!
>> 
>>> About the test, I don't see `ArrayList::add` in the generated bytecode of 
>>> `sub2-13`. The dedup string set is used for the targets of qualified 
>>> exports and opens and uses. The modifiers set of `requires` is deduplicated 
>>> but not the required module names.
>> 
>> Thank you for the hint.
>> 
>>> I assume you want this be backported. If so, we should give it some baked 
>>> time after it's integrated to the main line.
>> 
>> Sounds great!
>> 
>>> I'm okay if you want to extend the test in a follow up. 
>> 
>> That would be great. Will take time to craft a proper setting.
>
> @koppor do you have any update on a new test for 
> [JDK-8311591](https://bugs.openjdk.org/browse/JDK-8311591)?

@mlchung Pardon for the delay, we now created a PR with a test case 
https://github.com/openjdk/jdk/pull/15234

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14408#issuecomment-1673959119

Reply via email to