On Mon, 28 Aug 2023 18:45:03 GMT, Sean Coffey <[email protected]> wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simulate
>> loading of an external LoggerFinder service while also having other threads
>> poke System.getLogger during this framework initialization.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix up test cases
test/jdk/java/lang/System/LoggerFinder/RecursiveLoading/PlatformRecursiveLoadingTest.java
line 64:
> 62:
> logs.stream().map(SimpleLogRecord::of).forEach(System.out::println);
> 63:
> logs.stream().map(SimpleLogRecord::of).forEach(SimpleLogRecord::check);
> 64: assertEquals(String.valueOf(logs.size()), String.valueOf(2));
Suggestion:
assertEquals(String.valueOf(logs.size()), String.valueOf(3));
See suggestions to SimpleLoggerFinder below...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1307785939
