On Thu, 31 Aug 2023 06:53:45 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change which proposes to address > https://bugs.openjdk.org/browse/JDK-8233160? > > It has been noted in https://bugs.openjdk.org/browse/JDK-8232753 that: > >> The java.vendor.url.bug property has been defined by every Sun/Oracle JDK >> going all the way back to JDK 5 (and possibly earlier; JDK 5 is the oldest >> release that I can still run on my development machine). Yet, it's never >> been specified. > > The OpenJDK builds too by default set a value for this system property. > > The commit in this PR updates the javadoc of `System.getProperties()` to > include this system property in the list of specified properties. > Additionally, the `test/jdk/java/lang/System/PropertyTest.java` test has been > updated to verify that this property is indeed available in the Properties > returned by `System.getProperites()`. > > I'll create a CSR shortly for this change. I asked for Mark's and Joe's inputs on this in the linked JBS issue https://bugs.openjdk.org/browse/JDK-8233160. Mark has suggested that we keep this `java.vendor.url.bug` system property non-optional and also not to add any expectations of the value for this property to be a parsable URL. Both of those inputs match with what is currently proposed in this PR. I'll go ahead and draft a CSR shortly. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15504#issuecomment-1702893039
